Copy auto increment #911
Closed
Copy auto increment #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actions/Workflow: upload artifact
Support a complete ALTER TABLE statement in --alter
handle driver timeout error
Updates from upstream 2020 10
Initial commit: towards setting up a test suite Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…original table, applying AUTO_INCREMENT value onto ghost table if applicable and user has not specified AUTO_INCREMENT in alter statement
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
2 tasks
2 tasks
|
Merged in #967 👍 |
|
Woohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #381
Description
This PR ensures to copy
AUTO_INCREMENTvalue togh-osttable. The problem in #381 is that if rows are deleted from end of table, then the new table is created (or ends up) with a lower auto_increment value. I think most migrations do not encounter this issue because new rows are commonly added to the table while it's being migrated, naturally bumping up the ghost table'sAUTO_INCREMENTvalue to match the original table's. But for static tables this can happen.parses user's
-alterstatement to see if the user has specified any explicitAUTO_INCREMENTreads original table's
AUTO_INCREMENTvalue (if exists)if
AUTO_INCREMENTexists, and user has not overriden, apply original table'sAUTO_INCREMENTvalue onto the ghost table.tests added to verify behavior.
contributed code is using same conventions as original code
script/cibuildreturns with no formatting errors, build errors or unit test errors.Resubmission of openark#12