Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glb-director-xdp: Add statsd metrics. #113

Merged
merged 5 commits into from
Sep 16, 2020
Merged

glb-director-xdp: Add statsd metrics. #113

merged 5 commits into from
Sep 16, 2020

Conversation

theojulienne
Copy link
Contributor

This PR adds statsd metric support to glb-director-xdp. The metrics are collected using eBPF per-CPU structures, with the Go side doing housekeeping and emitting the metrics. The way these metrics are grouped should make tag-based aggregation fairly simple, and should also cover all paths/errors where the XDP program exits for any reason.

/cc #108

@theojulienne theojulienne requested a review from a team September 14, 2020 02:23
@theojulienne theojulienne self-assigned this Sep 14, 2020
Copy link
Contributor

@ross ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions/comments inline. Feel free to re-request review if you want me to take another look post discussion and (if any) changes.

src/glb-director-xdp/main.go Outdated Show resolved Hide resolved
src/glb-director-xdp/main.go Outdated Show resolved Hide resolved
src/glb-director-xdp/bpf/glb_encap.c Outdated Show resolved Hide resolved
@theojulienne theojulienne merged commit 448e7d3 into master Sep 16, 2020
@theojulienne theojulienne deleted the xdp-stats branch September 16, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants