This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
Adds "clipart me" command that returns clipart images from the openclipart API #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are actually moving away from adding scripts to repository in favor of separate npm packages per scripts. See #1113 for details, and let us know if you have any questions about getting going with that! |
| # hubot clipart me <query> - Queries openclipart for <query> and returns a random result. | ||
|
|
||
| module.exports = (robot) -> | ||
| robot.respond /(clipart)( me)? (.*)/i, (msg) -> |
There was a problem hiding this comment.
It's probably not worth capturing (clipart), since you don't use it. Nor is the optional me used. That means you could refactor to:
/clipart(?: me)? (.*)/
And then you'd be able to use msg.match[1] below.
|
@technicalpickles thanks for this. I will update and resubmit as its on package. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.