Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dev Container configuration #181

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

parkerbxyz
Copy link
Member

@parkerbxyz parkerbxyz commented Dec 20, 2023

This pull request creates a Dev Container configuration file and utilizes the existing Dockerfile to install the proper dependencies. This makes using, testing, and contributing via Codespaces much easier.

@parkerbxyz parkerbxyz marked this pull request as ready for review December 20, 2023 01:14
@parkerbxyz parkerbxyz self-assigned this Dec 20, 2023
@parkerbxyz
Copy link
Member Author

parkerbxyz commented Dec 20, 2023

I created this pull request using the GitHub Pull Requests and Issues VS Code extension, which unintentionally skipped the PR template. I saw the PR template when opening #182 and noticed some requirements in there that require dependencies (make) that are not included in the Dockerfile, resulting in the following error:

make: command not found

Should we add make to the Dockerfile?

@zkoppert
Copy link
Member

zkoppert commented Jan 9, 2024

I created this pull request using the GitHub Pull Requests and Issues VS Code extension, which unintentionally PR template. I saw the PR template when opening #182 and noticed some requirements in there that require dependencies (make) that are not included in the Dockerfile, resulting in the following error:

make: command not found

Should we add make to the Dockerfile?

Added make in fc015f3 for this.

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making developing easier!!

@zkoppert zkoppert merged commit 768025f into main Jan 9, 2024
5 checks passed
@zkoppert zkoppert deleted the parkerbxyz/devcontainer branch January 9, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants