Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pull_request target if we already have pull_request_target #297

Merged
merged 1 commit into from
May 28, 2024

Conversation

jmeridth
Copy link
Member

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

- [x] auto-labeler action
- [x] release action
- [x] fix codeql bade in README (after we removed custom workflow in #276)

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this May 28, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner May 28, 2024 17:16
@jmeridth
Copy link
Member Author

The fact the auto-labeler PR still worked is proof we don't need both pull_request target and pull_request_target targets.

@jmeridth jmeridth merged commit 581a7cf into main May 28, 2024
26 checks passed
@jmeridth jmeridth deleted the jm_pull_request_target_only branch May 28, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants