Add explicit dependency on JSON gem #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use >= 2.6.2 to include a [segfault fix](ruby/json@b59368a)
|
The Please review the pull request for any additional changes required and merge when ready. |
License updates for explicit-json-dependency
jonabc
added a commit
that referenced
this pull request
Aug 17, 2022
## 3.7.3 ### Fixed - Swift test fixtures build artifacts are now ignored (:tada: @CvX #524) - Running cargo test fixture setup no longer deletes test files (:tada: @CvX #525) - Bundler test fixtures are compatible with latest macOS silicon(:tada: @CvX #528) - Fix segfaults seen using licensed with ruby 3.0.4 (#530) - Fix compatibility with latest versions of bundler 2.3 (#535)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #529
Add an explicit dependency on the json gem >= 2.6.2 to include a fix on a segfault in json@2.6.1 with ruby 3.0.4.
I opted to not put any sort of upper bound on the dependency range to match the pre-existing behavior as much as possible. Before this change whatever version of the json gem was included with a ruby installation would be the version of the gem that gets used. That versioning scheme has no upper bound, so I excluded it in this change