Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language: Imba #6080

Closed
wants to merge 3 commits into from
Closed

Add Language: Imba #6080

wants to merge 3 commits into from

Conversation

familyfriendlymikey
Copy link
Contributor

@familyfriendlymikey familyfriendlymikey commented Sep 16, 2022

Checklist:

@familyfriendlymikey
Copy link
Contributor Author

Please let me know if there is anything I can do to help get this process going.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the OP with the PR template, it's there for a reason. You're also going to need to find a different grammar or add a licence to the grammar as we can't accept grammars without a licence. The CONTRIBUTING.md file has a link to the acceptable licenses.

@familyfriendlymikey
Copy link
Contributor Author

@lildude Thank you for reviewing. Edited my OP and added an MIT license to the grammar repo.

@lildude
Copy link
Member

lildude commented Oct 19, 2022

Thanks. You're going to need to update the cached license file too. Re-adding the grammar by replacing it with itself using script/add-grammar -r should do the trick.

@familyfriendlymikey
Copy link
Contributor Author

I ran

script/add-grammar -r imba-linguist-grammar https://github.com/familyfriendlymikey/imba-linguist-grammar

and waited about 3 minutes, after which git diff doesn't seem to have any changes other than moving the submodule to the end of .gitmodules, nothing about a cached license file. I tried other approaches like removing the grammar manually and reinstalling it but that didn't have any changes either.

@lildude
Copy link
Member

lildude commented Oct 19, 2022

🤔 Try committing the updated submodule and run bundle exec licensed cache -c vendor/licenses/config.yml. This should detect the difference in SHAs and download the updated license file.

@familyfriendlymikey
Copy link
Contributor Author

familyfriendlymikey commented Oct 19, 2022

I couldn't get it to work. I didn't want to take up too much of your time so I just decided to redo everything from scratch, and take the opportunity to move the grammar and sample repositories to the official Imba account. Here's the new PR: #6130.

I hope you don't mind, I think it should be possible to diff this branch and the new PR so you don't have to read everything from scratch. This worked for me:

gh pr checkout 6130
git remote add temp_ffm git@github.com:familyfriendlymikey/linguist.git
git fetch temp_ffm
git diff temp_ffm/master

Thanks again for all your help.

@lildude
Copy link
Member

lildude commented Oct 20, 2022

Closing in favour of #6130

@lildude lildude closed this Oct 20, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants