Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linter and Fix Vulnerable Dependency #121

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Update Linter and Fix Vulnerable Dependency #121

merged 6 commits into from
Nov 21, 2024

Conversation

ncalteen
Copy link
Collaborator

It looks like esbuild 0.23.0 was flagged as containing vulnerabilities when scanning with Grype. This PR updates the linting process to use a different linter with additional security checks. It also pins esbuild to a later version, fixing the flagged vulnerability.

@ncalteen ncalteen self-assigned this Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.12s
✅ JAVASCRIPT prettier 11 0 1.85s
✅ JSON jsonlint 23 0 1.11s
✅ JSON npm-package-json-lint yes no 0.58s
✅ JSON prettier 23 0 0.98s
✅ MARKDOWN markdownlint 8 0 0.67s
✅ REPOSITORY checkov yes no 21.88s
✅ REPOSITORY gitleaks yes no 0.68s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 18.34s
✅ REPOSITORY secretlint yes no 1.1s
✅ REPOSITORY trivy yes no 31.51s
✅ REPOSITORY trivy-sbom yes no 0.8s
✅ REPOSITORY trufflehog yes no 14.25s
✅ TYPESCRIPT prettier 30 0 1.56s
✅ YAML prettier 21 0 0.68s
✅ YAML yamllint 21 0 0.36s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@ncalteen ncalteen requested a review from Copilot November 21, 2024 18:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 21 changed files in this pull request and generated no suggestions.

Files not reviewed (13)
  • .eslintignore: Language not supported
  • .eslintrc.yml: Language not supported
  • .vscode/tasks.json: Language not supported
  • package.json: Language not supported
  • tsconfig.eslint.json: Language not supported
  • eslint.config.mjs: Evaluated as low risk
  • .github/workflows/linter.yml: Evaluated as low risk
  • .grype.yml: Evaluated as low risk
  • .mega-linter.yml: Evaluated as low risk
  • docs/supported-functionality.md: Evaluated as low risk
  • .github/workflows/codeql-analysis.yml: Evaluated as low risk
  • src/bootstrap.mts: Evaluated as low risk
  • src/command.ts: Evaluated as low risk

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@ncalteen ncalteen merged commit b55e1b9 into main Nov 21, 2024
4 checks passed
@ncalteen ncalteen deleted the ncalteen/stdlib branch November 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant