Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous dependency on rinku, fix jruby #1035

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

dometto
Copy link
Contributor

@dometto dometto commented Mar 28, 2017

This PR removes the dependency on the rinku gem from the .gemspec. This is because this dependency breaks support for jruby, and appears to be superfluous. (The dependency on github-linguist was just made optional in order to fix jruby support in #537 by @kivikakk -- however, I had overlooked the additional breaking dependency on rinku)

The dependency on rinku was first introduced into the Gemfile in e494209, and then turned into a hard dependency in the .gemspec in 4002376. It is unclear what the motivation for including rinku was in either case. The project does not appear to use it:

$ grep -ri rinku .
./github-markup.gemspec:  s.add_dependency "rinku"

/cc @bartkamphorst

@kivikakk
Copy link
Contributor

kivikakk commented Mar 30, 2017

While I'm 80% sure there was some reason for introducing it in e494209, I'm now completely unable to recall it. Thanks!

@kivikakk kivikakk merged commit e1f9662 into github:master Mar 30, 2017
@dometto
Copy link
Contributor Author

dometto commented Apr 1, 2017

Thanks @kivikakk! If you could bump the gem version in the near future that would be great.

@kivikakk
Copy link
Contributor

kivikakk commented Apr 3, 2017

Bumped! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants