Remove superfluous dependency on rinku, fix jruby #1035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on the
rinku
gem from the.gemspec
. This is because this dependency breaks support for jruby, and appears to be superfluous. (The dependency ongithub-linguist
was just made optional in order to fix jruby support in #537 by @kivikakk -- however, I had overlooked the additional breaking dependency onrinku
)The dependency on
rinku
was first introduced into theGemfile
in e494209, and then turned into a hard dependency in the.gemspec
in 4002376. It is unclear what the motivation for includingrinku
was in either case. The project does not appear to use it:/cc @bartkamphorst