Bump to metrics 0.22 #44
Merged
+37
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metrics-rs/metrics@metrics-v0.21.1...metrics-v0.22.0 There are some breaking changes: - metrics-rs/metrics#414 Added a generic recorder to `SetRecorderError` and removed `set_boxed_recorder` - metrics-rs/metrics#380 Added metadata to the metrics - metrics-rs/metrics#394 Reworked the macros
|
Hi @mbellani! Are there any blockers to merging this? Right now it is not possible to bump anything metrics related in our dependency chain (including the metrics core crate) since the version mismatch results in metrics not being emitted for anything using a version other than the one use by the exporter. |
|
Because this is a breaking change, we have to bump this crate's version number as well and do a release. I'll try to get it done tomorrow. |
|
Thanks for the PR! |
jorendorff
approved these changes
Jan 11, 2024
|
nice! thanks for the PR, we'll work on cutting a release asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metrics-rs/metrics@metrics-v0.21.1...metrics-v0.22.0
There are some breaking changes:
SetRecorderErrorand removedset_boxed_recorderregister_*anddescribe_*macros metrics-rs/metrics#394 Reworked the macrosThis makes the necessary adjustments and replaces #40.