Attempt to move webrick to the gemspec instead

github · Aug 6, 2024 · 0a6fecc · 0a6fecc
1 parent f430f40
commit 0a6fecc
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 8 deletions.
diff --git a/github-pages.gemspec b/github-pages.gemspec
@@ -27,6 +27,7 @@ Gem::Specification.new do |s|
   s.add_dependency("mercenary", "~> 0.3")
   s.add_dependency("nokogiri", ">= 1.16.2", "< 2.0")
   s.add_dependency("terminal-table", "~> 1.4")
+  s.add_dependency("webrick", "~> 1.8")
   s.add_development_dependency("jekyll_test_plugin_malicious", "~> 0.2")
   s.add_development_dependency("pry", "~> 0.10")
   s.add_development_dependency("rspec", "~> 3.3")

diff --git a/lib/github-pages/dependencies.rb b/lib/github-pages/dependencies.rb
@@ -9,7 +9,6 @@ class Dependencies
       # Jekyll
       "jekyll" => "3.10.0",
       "jekyll-sass-converter" => "1.5.2",
-      "webrick" => "1.8.1",
 
       # Converters
       "kramdown" => "2.4.0",

diff --git a/spec/github-pages/dependencies_spec.rb b/spec/github-pages/dependencies_spec.rb
@@ -6,7 +6,6 @@
   CORE_DEPENDENCIES = %w(
     jekyll kramdown kramdown-parser-gfm liquid rouge jekyll-sass-converter
     github-pages-health-check
-    webrick
   ).freeze
   PLUGINS = described_class::VERSIONS.keys - CORE_DEPENDENCIES
 

diff --git a/spec/github-pages/integration_spec.rb b/spec/github-pages/integration_spec.rb
@@ -309,10 +309,4 @@ def rm_destination
       expect(contents).to match("markdown: CommonMarkGhPages")
     end
   end
-
-  context "webrick" do
-    it "does nothing" do
-      # all is well
-    end
-  end
 end