Add webrick as Ruby 3 doesn’t include it #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’ve specified the BUNDLE_GEMFILE as the one that exists in the /src/site location (the source of the site being built) was preventing Jekyll from finding the installed dependencies.
This may be fixable by upgrading Jekyll as it is now declared as a dependency.
|
I would rather expect that the docker image uses the same ruby version by default as GitHub Pages publishing (still 2.x) |
|
Yep, me too (GHP is using Ruby 2.7.4), but it was upgraded to use 3.x in a1e407c in January. There’s a conversation in #898 where this was discussed it seems. |
yoannchaudet
approved these changes
Jul 18, 2024
Merged
TomHennen
referenced
this pull request
in slsa-framework/slsa
Aug 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://github.com/github/pages-gem) | `231` -> `232` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v232`](https://github.com/github/pages-gem/releases/tag/v232) [Compare Source](https://github.com/github/pages-gem/compare/v231...v232) #### What's Changed - Bump docker/build-push-action from 5 to 6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/916](https://github.com/github/pages-gem/pull/916) - Fix obscured gemfile issue by [@​mrmanc](https://github.com/mrmanc) in [https://github.com/github/pages-gem/pull/912](https://github.com/github/pages-gem/pull/912) - Add webrick as Ruby 3 doesn’t include it by [@​mrmanc](https://github.com/mrmanc) in [https://github.com/github/pages-gem/pull/914](https://github.com/github/pages-gem/pull/914) - Update nokogiri CVE-2024-25062 by [@​naxhh](https://github.com/naxhh) in [https://github.com/github/pages-gem/pull/911](https://github.com/github/pages-gem/pull/911) - Parkr jekyll3.10 by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/919](https://github.com/github/pages-gem/pull/919) - Fix improperly bound regex by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/921](https://github.com/github/pages-gem/pull/921) - Prep 232 by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/923](https://github.com/github/pages-gem/pull/923) #### New Contributors - [@​naxhh](https://github.com/naxhh) made their first contribution in [https://github.com/github/pages-gem/pull/911](https://github.com/github/pages-gem/pull/911) **Full Changelog**: github/pages-gem@v231...v232 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/slsa-framework/slsa). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Tom Hennen <TomHennen@users.noreply.github.com> Co-authored-by: Tom Hennen <TomHennen@users.noreply.github.com>
andrewpollock
referenced
this pull request
in google/osv-scanner
Aug 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://github.com/github/pages-gem) | `"~> 231"` -> `"~> 232"` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v232`](https://github.com/github/pages-gem/releases/tag/v232) [Compare Source](https://github.com/github/pages-gem/compare/v231...v232) #### What's Changed - Bump docker/build-push-action from 5 to 6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/916](https://github.com/github/pages-gem/pull/916) - Fix obscured gemfile issue by [@​mrmanc](https://github.com/mrmanc) in [https://github.com/github/pages-gem/pull/912](https://github.com/github/pages-gem/pull/912) - Add webrick as Ruby 3 doesn’t include it by [@​mrmanc](https://github.com/mrmanc) in [https://github.com/github/pages-gem/pull/914](https://github.com/github/pages-gem/pull/914) - Update nokogiri CVE-2024-25062 by [@​naxhh](https://github.com/naxhh) in [https://github.com/github/pages-gem/pull/911](https://github.com/github/pages-gem/pull/911) - Parkr jekyll3.10 by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/919](https://github.com/github/pages-gem/pull/919) - Fix improperly bound regex by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/921](https://github.com/github/pages-gem/pull/921) - Prep 232 by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/923](https://github.com/github/pages-gem/pull/923) #### New Contributors - [@​naxhh](https://github.com/naxhh) made their first contribution in [https://github.com/github/pages-gem/pull/911](https://github.com/github/pages-gem/pull/911) **Full Changelog**: github/pages-gem@v231...v232 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->
lehors
referenced
this pull request
in slsa-framework/slsa
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github-pages](https://github.com/github/pages-gem) | `231` -> `232` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>github/pages-gem (github-pages)</summary> ### [`v232`](https://github.com/github/pages-gem/releases/tag/v232) [Compare Source](https://github.com/github/pages-gem/compare/v231...v232) #### What's Changed - Bump docker/build-push-action from 5 to 6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/github/pages-gem/pull/916](https://github.com/github/pages-gem/pull/916) - Fix obscured gemfile issue by [@​mrmanc](https://github.com/mrmanc) in [https://github.com/github/pages-gem/pull/912](https://github.com/github/pages-gem/pull/912) - Add webrick as Ruby 3 doesn’t include it by [@​mrmanc](https://github.com/mrmanc) in [https://github.com/github/pages-gem/pull/914](https://github.com/github/pages-gem/pull/914) - Update nokogiri CVE-2024-25062 by [@​naxhh](https://github.com/naxhh) in [https://github.com/github/pages-gem/pull/911](https://github.com/github/pages-gem/pull/911) - Parkr jekyll3.10 by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/919](https://github.com/github/pages-gem/pull/919) - Fix improperly bound regex by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/921](https://github.com/github/pages-gem/pull/921) - Prep 232 by [@​yoannchaudet](https://github.com/yoannchaudet) in [https://github.com/github/pages-gem/pull/923](https://github.com/github/pages-gem/pull/923) #### New Contributors - [@​naxhh](https://github.com/naxhh) made their first contribution in [https://github.com/github/pages-gem/pull/911](https://github.com/github/pages-gem/pull/911) **Full Changelog**: github/pages-gem@v231...v232 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/slsa-framework/slsa). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com> Co-authored-by: Arnaud J Le Hors <lehors@us.ibm.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752.
webrickwasn’t available it’s not bundled as of Ruby v3.0.0. I’ve resolved this by adding it to the dependencies class.