Allow private zones with an SOA to satisfy apex_domain? #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Apr 22, 2021
feat(domain): report if an SOA record exists for a domain
|
Merged in the changes here instead. Will continue iterating on this PR. |
parkr
approved these changes
May 26, 2021
parkr
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where a subdomain may want to be considered an "Apex", even if it's not on the public suffix. This requires that the domain should have an SOA record present. This will help suppress messages where we're recommending users setup a CNAME on a subdomain that is otherwise the "apex" of the zone. We might instead want to just return the value of
dns_zone_soa?and handle the error messages more explicitly. Will think about this some more.