Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #142

Merged
merged 7 commits into from
Jan 14, 2023
Merged

Spelling #142

merged 7 commits into from
Jan 14, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 9, 2022

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@293dbce#commitcomment-68282379

The action reports that the changes in this PR would make it happy: jsoref@4de809f

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

jsoref added 6 commits March 8, 2022 20:59
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
expect(subject.controls_ip?(IPAddr.new("200.27.128.55"))).to be_falsey
expect(subject.controls_ip?(IPAddr.new("200.27.128.55"))).to be_falsy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know both are supported, but this was the only case of the longer flavor.

Copy link
Member

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections!

@JamesMGreene JamesMGreene merged commit ae25666 into github:master Jan 14, 2023
@jsoref jsoref deleted the spelling branch January 14, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants