Add support for using a network proxy to make outgoing web requests #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James M. Greene <JamesMGreene@github.com>
This test does not ensure that web requests are actually *made* with the specified proxy. That is currently beyond the ability of WebMock to assert (bblimke/webmock#753). However Typhoeus does raise an exception when an invalid option is passed to its Request object, so we can be reasonably assured that Typhoeus will in fact receive the intended proxy url and use it.
YiMysty
approved these changes
Jun 8, 2022
JamesMGreene
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
GitHubPages::HealthCheck.set_proxy(proxy_url)method. When used, all subsequent uses of the gem will force HTTP traffic through a proxy atproxy_url.