check for underscore for https #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooManyBees
previously approved these changes
Oct 11, 2022
parkr
reviewed
Oct 11, 2022
|
|
||
| # Can't have underscores in the domain name | ||
| return false if host.include?("_") |
There was a problem hiding this comment.
Should this invalidate the domain name as well, or just HTTPS eligibility? Does GitHub have many customer custom domains with underscores?
There was a problem hiding this comment.
Hello there!
We do have people on HTTP only and with a _ in their domain name unfortunately 🙈. Some are using Cloudflare which does issue certs, but Let's Encrypt does not.
There was a problem hiding this comment.
Gotta love the edge cases! 😄
yoannchaudet
previously approved these changes
Oct 11, 2022
yoannchaudet
dismissed stale reviews from TooManyBees and themself
via
e9b9079
yoannchaudet
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for underscores for custom domain certificates