Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent linkification when replacing a URL #30

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Prevent linkification when replacing a URL #30

merged 3 commits into from
Oct 27, 2021

Conversation

steffen
Copy link
Contributor

@steffen steffen commented Oct 25, 2021

This change prevents the linkification when replacing a URL.

This refinement is addressing this internal feedback.

@steffen steffen requested a review from a team as a code owner October 25, 2021 19:24
@steffen steffen requested review from dgreif and manuelpuyol October 25, 2021 19:24
koddsson
koddsson approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/test.js
Comment on lines +39 to +40
// Synthetic paste events don't manipulate the DOM. The same textarea value
// means that the event handler didn't fire and normal paste happened.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good comment since the test behaviour is weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koddsson 💯 "Stole" it from

paste-markdown/test/test.js

Lines 102 to 103 in a447563

// Synthetic paste events don't manipulate the DOM. A empty textarea
// means that the event handler didn't fire and normal paste happened.
😊

test/test.js Outdated Show resolved Hide resolved
steffen and others added 2 commits October 26, 2021 14:12
@srt32 srt32 enabled auto-merge October 27, 2021 21:53
@srt32 srt32 merged commit 0e8fb6e into github:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

@srt32 srt32 srt32 approved these changes

@dgreif dgreif Awaiting requested review from dgreif dgreif was automatically assigned from github/ui-frameworks-reviewers

@manuelpuyol manuelpuyol Awaiting requested review from manuelpuyol manuelpuyol was automatically assigned from github/ui-frameworks-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steffen @koddsson @srt32