Fix duration calculation

[wxiaoguang]

Fix duration calculation

The simplest fix for #250 (comment) , not ideal, just a quick fix.

[silverwind]

Maybe a test can be added here:

relative-time-element/test/duration.ts

Line 231 in e914da2

suite('roundToSingleUnit', function () {

[wxiaoguang]

Maybe a test can be added here:

relative-time-element/test/duration.ts

Line 231 in e914da2

suite('roundToSingleUnit', function () {

If the project members have interests in this PR, I could add later.

[francinelucca]

Thanks so much for diving into this @wxiaoguang! Looks like this proposed solution is causing one test to fail so we're unable to merge it at this time.
If you'd like to take a stab at fixing the tests you're welcome to do so, if not someone from the team will pick this up when we have the availability to do so.

You should be able to run the tests locally using npm run test

[wxiaoguang]

Thanks so much for diving into this @wxiaoguang! Looks like this proposed solution is causing one test to fail so we're unable to merge it at this time. If you'd like to take a stab at fixing the tests you're welcome to do so, if not someone from the team will pick this up when we have the availability to do so.

You should be able to run the tests locally using npm run test

But that failure seems not related. I have noticed that even on main branch, it still fails (that's another reason why I didn't touch the test code, I just would like to see whether it fails in your CI tasks).

 ❌ relative-time > [tense=future] > micro formats years
      AssertionError: expected '11y' to equal '10y'
      + expected - actual
      
      -11y
      +10y
      
      at n4.<anonymous> (test/relative-time.js:609:13)

[wxiaoguang]

The 11y vs 10y failure is caused by another bug in elapsedTime, const month = Math.floor(day / 30) is not right when the period is long enough.

[francinelucca]

Confirmed CI failure is present in prod, in that case I think we can move forward with this. @wxiaoguang Just have a logic question and adding tests I think is a great idea :)

[wxiaoguang]

A test is added in fc858c3 and added comments to clarify the problem.

[wxiaoguang]

And made one more commit: if we'd like to support "11 months": 60bc336 corrected the behavior and fixed the tests.

Feel free to choose the behavior you like.

[wxiaoguang]

"Fixed" the "10y vs 11y" problem in da833cf, now the CI should be able to pass

[viceice]

🚀 ❤️

[keithamus]

This LGTM

[francinelucca]

Merged! Thanks so much for doing this @wxiaoguang