Install remoteForm directly onto passed element.
#33
Conversation
remoteForm can install itself onto any element that matches passed selector. In some cases, you might want to install remoteForm onto a specific form element without having to assign this form an `id` just to make it selectable. This change allows passing a `HTMLFormElement` reference to remoteForm directly.
| @@ -45,6 +45,11 @@ describe('remoteForm', function () { | |||
| document.querySelector('button[type=submit]').click() | |||
| }) | |||
|
|
|||
| it('installs remoteForm on form reference', function (done) { | |||
| remoteForm(htmlForm, async () => done()) | |||
| document.querySelector('button[type=submit]').click() | |||
There was a problem hiding this comment.
This test is missing any assertions.
Can you please take a look at the test above and add some assertions to insure that the expected behaviour is indeed being installed on the element.
There was a problem hiding this comment.
Thanks for your feedback!
I was solely relying on Jasmine's done() to verify that the installed handler runs. I've extended the test to verify that we've installed remoteForm on the correct form element 👍
There was a problem hiding this comment.
Okay thank you for the update. Given that this is testing that the form is installed on the passed reference, I think this test is more complete.
| @@ -45,6 +45,11 @@ describe('remoteForm', function () { | |||
| document.querySelector('button[type=submit]').click() | |||
| }) | |||
|
|
|||
| it('installs remoteForm on form reference', function (done) { | |||
| remoteForm(htmlForm, async () => done()) | |||
| document.querySelector('button[type=submit]').click() | |||
There was a problem hiding this comment.
Okay thank you for the update. Given that this is testing that the form is installed on the passed reference, I think this test is more complete.
|
awesome, thank you @theinterned! :-) |
Hi,
remoteForm can install itself onto any element that matches passed selector. In some cases, you might want to install remoteForm onto a specific form element without having to assign this form an
idjust to make it selectable.This change allows passing a
HTMLFormElementreference to remoteForm directly.Let me know what you think and if that change fits into the overall design of remoteForm!