Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for autolinks in safe-settings #212

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

markjm
Copy link
Contributor

@markjm markjm commented Apr 27, 2022

Includes autolinks as a setting the app can handle and manage. If the autolinks field is not populated, this is a no-op.

Docs about autolinks here https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources

Follows defined "diffable" pattern, so no change really.

Also moved removals of diffs before additions due to bugs with the previous ordering (if you reach max number of autolinks/labels/etc, then adding before removing will cause issues) - removing before adding will "make space" when needed. Not a common issue, but I ran int it while testing

@svg153
Copy link
Contributor

svg153 commented May 20, 2022

Just to link similar PRs:

@@ -0,0 +1,69 @@
const Diffable = require('./diffable');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a test too to make sure it works in the future ?

@daronmcintosh
Copy link

any word on when this'll be merged?

@decyjphr decyjphr merged commit 5c80932 into github:main-enterprise Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants