Add support for new lock syntax in MySQL8 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Carnahan <patrickcarnahan@github.com>
patrickcarnahan
force-pushed
the
patrickcarnahan/mysql8-lock-syntax
branch
from
46eb82b
to
bc06477
Compare
patrickcarnahan
commented
Aug 7, 2023
| @@ -1004,7 +1004,7 @@ INPUT | |||
| SELECT 1 FOR SHARE UNION SELECT 2; | |||
| END | |||
| ERROR | |||
| syntax error at position 19 near 'SHARE' | |||
There was a problem hiding this comment.
this actually matches the error mysql8 provides when issuing the same query via explain:
mysql> explain select 1 for share union select 2;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'union select 2' at line 1
| @@ -6868,6 +6868,26 @@ FOR UPDATE | |||
| { | |||
| $$ = ForUpdateLock | |||
| } | |||
| | FOR UPDATE NOWAIT | |||
There was a problem hiding this comment.
not sure if there is a "better" way to do this, but i saw this type of pattern elsewhere so seemed to make sense.
|
I'm going to merge this as we tested this out and it was working as expected. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This completes the work to enable the following syntax in vitess:
SELECT .. FOR SHARE (NOWAIT|SKIP LOCKED)SELECT .. FOR UPDATE (NOWAIT|SKIP LOCKED)The aim is to finish the work started in vitessio#5336, which added the keywords to the syntax but didn't modify the ast and other functions to handle it.
Related Issue(s)
Fixes vitessio#5249
Checklist
Deployment Notes