Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
  • Loading branch information
asgerf and aeisenberg authored Nov 20, 2024
1 parent bb1da9c commit 38849f7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions extensions/ql-vscode/src/common/jsonl-reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const doubleLineBreakRegexp = /\n\r?\n/;
export async function readJsonlFile<T>(
path: string,
handler: (value: T) => Promise<void>,
logger?: { log: (message: string) => void },
logger?: BaseLogger,
): Promise<void> {
// Stream the data as large evaluator logs won't fit in memory.
// Also avoid using 'readline' as it is slower than our manual line splitting.
Expand Down Expand Up @@ -48,7 +48,7 @@ export async function readJsonlFile<T>(
return;
}
}
void logger?.log(`Finishing parsing ${path}`);
void logger?.log(`Finished parsing ${path}`);
resolve();
});
stream.on("error", reject);
Expand Down

0 comments on commit 38849f7

Please sign in to comment.