QuickEval:Address review comments

github · Jun 20, 2023 · 86c9ec7 · 86c9ec7
1 parent 3ecd754
commit 86c9ec7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md
@@ -15,6 +15,8 @@
 - Add warning when using unsupported CodeQL CLI version. [#2428](https://github.com/github/vscode-codeql/pull/2428)
 - Retry variant analysis results download if connection times out. [#2440](https://github.com/github/vscode-codeql/pull/2440)
 - Add `CodeQL: Quick Evaluation Count` command to generate the count of the selected item without having to compute locations or strings.
+- Add `CodeQL: Quick Evaluation Count` command to generate the count summary statistics of the results set
+  without speding the time to compute locations and strings.
 
 ## 1.8.4 - 3 May 2023
 

diff --git a/extensions/ql-vscode/src/local-queries/local-queries.ts b/extensions/ql-vscode/src/local-queries/local-queries.ts
@@ -36,7 +36,7 @@ import {
 import { CompletedLocalQueryInfo, LocalQueryInfo } from "../query-results";
 import { WebviewReveal } from "./webview";
 import { asError, getErrorMessage } from "../pure/helpers-pure";
-import { CodeQLCliServer } from "../codeql-cli/cli";
+import { CliVersionConstraint, CodeQLCliServer } from "../codeql-cli/cli";
 import { LocalQueryCommands } from "../common/commands";
 import { App } from "../common/app";
 import { DisposableObject } from "../pure/disposable-object";
@@ -237,7 +237,7 @@ export class LocalQueries extends DisposableObject {
       async (progress, token) => {
         if (!(await this.cliServer.cliConstraints.supportsQuickEvalCount())) {
           throw new Error(
-            "Quick evaluation counts is not supported by this version of CodeQL CLI.",
+            `Quick evaluation count is only supported by CodeQL CLI v${CliVersionConstraint.CLI_VERSION_WITH_QUICK_EVAL_COUNT} or later.`,
           );
         }
         await this.compileAndRunQuery(