Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database import fails when folder is prefixed with db- #1561

Closed
hvitved opened this issue Oct 3, 2022 · 4 comments · Fixed by #1565
Closed

Database import fails when folder is prefixed with db- #1561

hvitved opened this issue Oct 3, 2022 · 4 comments · Fixed by #1565
Labels
bug Something isn't working VSCode

Comments

@hvitved
Copy link
Contributor

hvitved commented Oct 3, 2022

Describe the bug

image

It is not a big problem, except the DBs we download from DCA all contain this prefix.
@hvitved hvitved added the bug Something isn't working label Oct 3, 2022
@github-actions github-actions bot added the VSCode label Oct 3, 2022
@hvitved
Copy link
Contributor Author

hvitved commented Oct 3, 2022

Ping @esbena so you are aware as well (perhaps the easiest fix is just for DCA to not add the db- prefix).

@esbena
Copy link

esbena commented Oct 3, 2022

Can you check if database- is an acceptable prefix?

@hvitved
Copy link
Contributor Author

hvitved commented Oct 3, 2022

It is.

@aeisenberg aeisenberg mentioned this issue Oct 3, 2022
Merged
3 tasks
@aeisenberg
Copy link
Contributor

I put in a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working VSCode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use better heuristics when checking db folders github/vscode-codeql
3 participants
@aeisenberg @esbena @hvitved