Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better heuristics when checking db folders #1565

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Use better heuristics when checking db folders #1565

merged 2 commits into from
Oct 3, 2022

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Oct 3, 2022 •
edited
Loading

Small fix that allows users to add databases even if the database root folder starts with db-.

Fixes #1561

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@aeisenberg aeisenberg requested a review from a team as a code owner October 3, 2022 21:06
@aeisenberg aeisenberg changed the title Use better heuristics when chekcking db folders Use better heuristics when checking db folders Oct 3, 2022
angelapwen
angelapwen approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! The tests make the functionality very clear 😸

extensions/ql-vscode/src/vscode-tests/no-workspace/helpers.test.ts Outdated Show resolved Hide resolved
@aeisenberg @angelapwen
Update extensions/ql-vscode/src/vscode-tests/no-workspace/helpers.tes…
924d24b 
…t.ts

Co-authored-by: Angela P Wen <angelapwen@github.com>
@aeisenberg aeisenberg merged commit 011eee1 into main Oct 3, 2022
@aeisenberg aeisenberg deleted the aeisenberg/db-folder-check branch October 3, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database import fails when folder is prefixed with db-
2 participants
@aeisenberg @angelapwen