-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new command to open the query history directory #1179
Add new command to open the query history directory #1179
Conversation
4303608
to
3b6021b
Compare
301b612
to
6fbf435
Compare
Does this work with Codespaces? As far as I can tell, it instructs the host OS to open the folder, and I'm not sure that works properly when the machine that has the directory is hosted in the cloud somewhere. |
6abc4ee
to
b4f63e8
Compare
6fbf435
to
cc8b7ae
Compare
Good question. I have not tried this on codespaces. I'm not even sure what the expected behaviour should be. Probably the best result would be to disable the command if the file system is remote. It looks like there is already a precedent for that with the Reveal in Finder command (and the equivalent in linux/windows) not being available in codespaces. |
cc8b7ae
to
3754309
Compare
Added this line and verified on codespaces that the option does not show: |
In that case, I do not see how this PR "Fixes #1174 (comment)", as that comment pertains directly to the use of Codespaces. |
Hmmm...right. At least now, a broken command won't be visible in codespaces. Also, this logs will stick around after restarts. All the data is stored in the workspace storage folder. You need to ensure that the workspace remains the same across restarts. This command is quite useful in non-remote situations and is something I wanted to implement anyway. I will take a look at a way to copy the path to the clipboard later. |
b2b8625
to
f28c1f9
Compare
Allows users to explore the contents and all artifacts of the query that was just run.
3754309
to
025a1a1
Compare
Query logs will be saved in subdirectories of |
Allows users to explore the contents and all artifacts of the query
that was just run.
Fixes #1174 (comment)
cc: @tausbn
Checklist
ready-for-doc-review
label there.