Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "result format" dropdown in results view for (path-)problem queries #2745

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Aug 24, 2023

For variant analyses with interpreted results (i.e. problem queries or path-problem queries), users should have the option to display raw results (see internal linked issue for details).

image

This PR adds the new dropdown from #2743 to the MRVA results view, but only for queries that have a path-problem or problem kind. (Otherwise there's only one display format anyway)

Note: The dropdown currently has no effect 🙃 For the final piece of the puzzle, I'll open a PR that actually uses the result format to control the result display! (It's in progress, stay tuned 😎)

Checklist

N/A (I'll update the changelog in the final PR that strings things together)

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Base automatically changed from shati-patel/result-format to main August 24, 2023 14:42
@shati-patel shati-patel force-pushed the shati-patel/result-format-view branch from ab4d375 to f8d542d Compare August 24, 2023 14:44
@shati-patel shati-patel changed the title Display "result format" dropdown for (path-)problem MRVA queries Display "result format" dropdown in results view for (path-)problem queries Aug 24, 2023
@shati-patel shati-patel marked this pull request as ready for review August 24, 2023 14:45
@shati-patel shati-patel requested a review from a team as a code owner August 24, 2023 14:45
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@shati-patel shati-patel merged commit 4a87a6f into main Aug 25, 2023
22 of 23 checks passed
@shati-patel shati-patel deleted the shati-patel/result-format-view branch August 25, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants