Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "CodeQL: Trim Cache" command that calls evaluation/trimCache #2928

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Add "CodeQL: Trim Cache" command that calls evaluation/trimCache #2928

merged 3 commits into from
Oct 13, 2023

Commits on Oct 12, 2023

  1. Add "VSCode: Trim Cache" command that calls evaluation/trimCache 

    The purpose of this change is to add a command that clears the cache except for predicates marked `cached`.
In contrast, the existing "VSCode: Clear Cache" command clears everything (`--mode=brutal`).

This calls into the query server's `evaluation/trimCache` method;
however, its existing behaviour is to do a database cleanup with `--mode=gentle`.
This is not well documented, and `--mode=normal` would give the desired behaviour.

Accordingly, this approach is dependent on separately changing the backend behaviour to `--mode=normal`.

Other possible amendments to this commit would be to not touch the legacy client
(replacing required methods by failing promises, since the legacy server is fully deprecated already),
or to have less duplication (by introducing more arguments — however,
I'm applying the rule of thumb that >3 copy-pastes are required for the introduction of a deduplicating abstraction).
    @d10c
    d10c committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d0f4188 View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG.md entry

    @d10c
    d10c committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8b918bd View commit details
    Browse the repository at this point in the history

  3. Make the command conditional on a supported CLI version

    @d10c
    d10c committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b097804 View commit details
    Browse the repository at this point in the history