Fix results directory and evaluator log for cancelled queries #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koesie10
force-pushed
the
koesie10/query-save-dir
branch
from
838e054
to
6af72f4
Compare
This will add the `QueryOutputDir` to the `InitialQueryInfo` and populate it when creating a local query history item. This will allow us to open the results directory or show the evaluator log without a completed query.
This will ensure that when "Show Evaluator Log (Raw JSON)" is used on a cancelled query history item, we will still show it if it exists. This changes the error messages on other cases to be more specific.
When a local query fails (for example, if it is cancelled), it may still have an evaluation log. We weren't generating evaluation log summaries in these cases, so the options to view the summary text and to use the evaluation log viewer would not be available. This fixes it by also trying to generate the summary in the case of a failed query.
koesie10
force-pushed
the
koesie10/query-save-dir
branch
from
8294939
to
18646ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a change to the query history format to save the output directory of the query. This will allow us to open the results directory and show the evaluator log for queries which have been cancelled.
I've also tested that it handles opening an older query history item format. In that case, it will try to recreate the output dir from a completed query, which should always work since we don't store non-completed queries in the query history JSON.
Please review this commit-by-commit.
Checklist
ready-for-doc-reviewlabel there.