Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates an empty .expected file when running test output compare #669

Merged

Conversation

aeisenberg
Copy link
Contributor

If the expected file does not already exists. This helps with test
creation and allows users to create tests more quickly.

Fixes #338.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] @github/docs-content-dsp has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@aeisenberg aeisenberg added the Complexity: Low A good task for newcomers to learn, or experienced team members to complete quickly. label Nov 3, 2020
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible.
@rdmarsh2 or @dbartol do you know if we have test cases without an .expected file (rather than having an empty file)? Do consistency checks use this pattern? Just want to make sure we're not spuriously creating empty .expected files during extension use.

@rdmarsh2
Copy link

rdmarsh2 commented Nov 9, 2020

To my knowledge, we don't. All the C++ consistency checks are done with multiple query predicates imported into a single .qll, so they have predicate names in the .expected files even if they pass.

@adityasharad
Copy link
Contributor

Thanks! In that case, LGTM once conflicts are resolved.

If the expected file does not already exists. This helps with test
creation and allows users to create tests more quickly.
@aeisenberg aeisenberg force-pushed the aeisenberg/create-empty-expected branch from d6b59d7 to b163669 Compare November 9, 2020 22:27
@aeisenberg aeisenberg merged commit f4998d9 into github:main Nov 9, 2020
@aeisenberg aeisenberg deleted the aeisenberg/create-empty-expected branch November 24, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low A good task for newcomers to learn, or experienced team members to complete quickly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In test diffs, compare the result to an empty file if no .expected file exists
3 participants