Add a codeql status bar item #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/status-bar
branch
from
26e8c7d to
b5e0537
Compare
|
Squirrel icon, not a bird. |
aeisenberg
force-pushed
the
aeisenberg/status-bar
branch
from
b5e0537 to
12f44fd
Compare
|
Removing the squirrel. Too small and hard to see. |
aeisenberg
force-pushed
the
aeisenberg/status-bar
branch
from
12f44fd to
daf478f
Compare
adityasharad
reviewed
Feb 2, 2021
| this.item.text = `CodeQL${canary}`; | ||
|
|
||
| const version = await this.cli.getVersion(); | ||
| this.item.text = `CodeQL cli v${version}${canary}`; |
There was a problem hiding this comment.
Do you think we should include both the extension version and the CLI version here? (Is there room?)
Suggested change
| this.item.text = `CodeQL cli v${version}${canary}`; | |
| this.item.text = `CodeQL CLI v${version}${canary}`; |
There was a problem hiding this comment.
There's already a standard place to check the extension version. So, I'd rather not take up more precious space in the status bar.
Includes the current cli version as well as the canary status (codeQL.canary) in the settings.
aeisenberg
force-pushed
the
aeisenberg/status-bar
branch
from
daf478f to
1d0e553
Compare
adityasharad
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the current cli version as well as the canary status (codeQL.canary) in the settings.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.