Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a license cluster command #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dtaivpp
Copy link

@dtaivpp dtaivpp commented Nov 7, 2024

In order to securely add licensing to our Elasticsearch clusters I have added LicenseCluster action. This action takes in a string containing the json license and applies it to the cluster.

This is just one component that will be used in the licensing workflow from vulcan-go.

Tracking issue here: https://github.com/github/elasticsearch/issues/4211

@hoenn hoenn requested a review from a team November 7, 2024 18:56
@@ -1802,3 +1802,24 @@ func (c *Client) RemoveIndexILMPolicy(index string) error {

return nil
}

// Function called LicenseCluster. This function takes a json document as a string which is the license to apply to the Elasticsearch cluster.
Copy link
Contributor

@hoenn hoenn Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A properly formed godoc func header comment should look like:

// LicenseCluster ...

@hoenn
Copy link
Contributor

hoenn commented Nov 7, 2024

Should be able to write a test for this new functionality.

@dtaivpp
Copy link
Author

dtaivpp commented Nov 7, 2024

@hoenn I plan to, I'm just pulling it together to start getting eyes on them. 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants