Skip to content

Commit

Permalink
Update to rome stable.
Browse files Browse the repository at this point in the history
Includes workarounds for:
- rome/tools#3734
- rome/tools#3735
  • Loading branch information
lgarron committed Nov 15, 2022
1 parent 8e72298 commit a4a1128
Show file tree
Hide file tree
Showing 4 changed files with 64 additions and 112 deletions.
162 changes: 57 additions & 105 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"esbuild": "^0.15.13",
"jest": "^29.2.2",
"jest-environment-jsdom": "^29.2.2",
"rome": "^0.10.1-next",
"rome": "^10.0.1",
"ts-jest": "^29.0.3",
"typescript": "^4.8.4"
},
Expand Down
5 changes: 1 addition & 4 deletions rome.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
"linter": {
"enabled": true,
"rules": {
"recommended": true,
"correctness": {
"useSimplifiedLogicExpression": "off"
}
"recommended": true
}
}
}
7 changes: 5 additions & 2 deletions src/webauthn-json/basic/supported.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
// https://developers.google.com/web/updates/2018/03/webauthn-credential-management

export function supported(): boolean {
// rome-ignore format: Work around https://github.com/rome/tools/issues/3734
return !!(
navigator.credentials?.create &&
// rome-ignore lint(style/useOptionalChain): Optional chaining creates more complicated ES2019 code
navigator.credentials &&
navigator.credentials.create &&
navigator.credentials.get &&
globalThis.PublicKeyCredential
window.PublicKeyCredential
);
}

0 comments on commit a4a1128

Please sign in to comment.