Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changeset in details with details #162

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Changeset in details with details #162

merged 3 commits into from
Aug 5, 2022

Conversation

mattcosta7
Copy link
Member

@mattcosta7 mattcosta7 commented Aug 5, 2022 •
edited
Loading

Makes the changset default to a hidden details, with the extended file size info in another details.

we should probably make these a bit less duplicative over time, but for now that seems ok.

updates tests to use snapshots instead of inline strings, because hand writing them is not fun

@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

Bundle Stats-With chunk and module information

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Type Total bundle size % Changed
2 bundled 1.98 MB 0%
**Changeset**
File Δ
src/client/this/file/has/a/long/name/so-that-it-will-hopefully-wrap.tsx 🆕 +2.72 KB
src/client/this-file-was-added.ts 🆕 +1.46 KB
src/client/this-is-another-file-with-a-long-name-to-test-the-table-sizing.tsx 🆕 +1.04 KB
src/client/helpers/this-file-is-much-larger.ts 📈 +11.66 KB (+865.77%)
src/client/this-file-grew-larger.tsx 📈 +200 B (+35.59%)
src/client/helpers/this-file-grew-smaller.ts 📉 -200 B (-7.94%)
src/client/this-file-is-much-smaller.tsx 📉 -11.66 KB (-99.92%)
src/client/routes.tsx 🔥 -2.72 KB (-100%)
src/client/this-file-will-be-deleted.ts 🔥 -1.46 KB (-100%)
src/client/render-memex.tsx 🔥 -1.04 KB (-100%)
View individual file sizes
File Old New Δ
src/client/this/file/has/a/long/name/so-that-it-will-hopefully-wrap.tsx 0 B 2.72 KB 🆕 +2.72 KB
src/client/this-file-was-added.ts 0 B 1.46 KB 🆕 +1.46 KB
src/client/this-is-another-file-with-a-long-name-to-test-the-table-sizing.tsx 0 B 1.04 KB 🆕 +1.04 KB
src/client/helpers/this-file-is-much-larger.ts 1.35 KB 13.01 KB 📈 +11.66 KB (+865.77%)
src/client/this-file-grew-larger.tsx 562 B 762 B 📈 +200 B (+35.59%)
src/client/helpers/this-file-grew-smaller.ts 2.46 KB 2.26 KB 📉 -200 B (-7.94%)
src/client/this-file-is-much-smaller.tsx 11.67 KB 10 B 📉 -11.66 KB (-99.92%)
src/client/routes.tsx 2.72 KB 0 B 🔥 -2.72 KB (-100%)
src/client/this-file-will-be-deleted.ts 1.46 KB 0 B 🔥 -1.46 KB (-100%)
src/client/render-memex.tsx 1.04 KB 0 B 🔥 -1.04 KB (-100%)
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Type File Size % Changed
app.bundle.js bundled 1.98 MB 0%
manifest.json bundled 91 B 0%

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Type Total bundle size % Changed
7 -> 2 bundled
gzip		 1.34 MB -> 1.29 MB (-53.65 KB)
386.44 KB -> N/A		 -3.91%
View detailed bundle breakdown

Added

No assets were added

Removed

Asset Type File Size % Changed
296.chunk.js bundled
gzip		 124.57 KB -> 0 B (-124.57 KB)
35.05 KB -> 0 B		 -100%
288.chunk.js bundled
gzip		 57.24 KB -> 0 B (-57.24 KB)
16.33 KB -> 0 B		 -100%
920.chunk.js bundled
gzip		 54.98 KB -> 0 B (-54.98 KB)
17.08 KB -> 0 B		 -100%
912.chunk.js bundled
gzip		 44.37 KB -> 0 B (-44.37 KB)
14.31 KB -> 0 B		 -100%
699.chunk.js bundled
gzip		 26.39 KB -> 0 B (-26.39 KB)
6.14 KB -> 0 B		 -100%

Bigger

Asset Type File Size % Changed
app.bundle.js bundled
gzip		 1.04 MB -> 1.29 MB (+254.35 KB)
297.38 KB -> N/A		 +23.91%

Smaller

Asset Type File Size % Changed
manifest.json bundled
gzip		 551 B -> 91 B (-460 B)
151 B -> N/A		 -83.48%

Unchanged

No assets were unchanged

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Bundle Stats-Flipped around

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Type Total bundle size % Changed
2 -> 7 bundled
gzip		 1.29 MB -> 1.34 MB (+53.65 KB)
N/A -> 386.44 KB		 +4.07%
View detailed bundle breakdown

Added

Asset Type File Size % Changed
296.chunk.js bundled
gzip		 0 B -> 124.57 KB (+124.57 KB)
0 B -> 35.05 KB		 -
288.chunk.js bundled
gzip		 0 B -> 57.24 KB (+57.24 KB)
0 B -> 16.33 KB		 -
920.chunk.js bundled
gzip		 0 B -> 54.98 KB (+54.98 KB)
0 B -> 17.08 KB		 -
912.chunk.js bundled
gzip		 0 B -> 44.37 KB (+44.37 KB)
0 B -> 14.31 KB		 -
699.chunk.js bundled
gzip		 0 B -> 26.39 KB (+26.39 KB)
0 B -> 6.14 KB		 -

Removed

No assets were removed

Bigger

Asset Type File Size % Changed
manifest.json bundled
gzip		 91 B -> 551 B (+460 B)
N/A -> 151 B		 +505.49%

Smaller

Asset Type File Size % Changed
app.bundle.js bundled
gzip		 1.29 MB -> 1.04 MB (-254.35 KB)
N/A -> 297.38 KB		 -19.29%

Unchanged

No assets were unchanged

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Bundle Stats-Non existent

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Type Total bundle size % Changed
0 bundled 0 B 0%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Bundle Stats-No changes

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Type Total bundle size % Changed
7 bundled
gzip		 1.34 MB
386.44 KB		 0%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Type File Size % Changed
app.bundle.js bundled
gzip		 1.04 MB
297.38 KB		 0%
296.chunk.js bundled
gzip		 124.57 KB
35.05 KB		 0%
288.chunk.js bundled
gzip		 57.24 KB
16.33 KB		 0%
920.chunk.js bundled
gzip		 54.98 KB
17.08 KB		 0%
912.chunk.js bundled
gzip		 44.37 KB
14.31 KB		 0%
699.chunk.js bundled
gzip		 26.39 KB
6.14 KB		 0%
manifest.json bundled
gzip		 551 B
151 B		 0%

@mattcosta7 mattcosta7 self-assigned this Aug 5, 2022
@mattcosta7 mattcosta7 requested review from a team and camchenry August 5, 2022 14:12
@mattcosta7 mattcosta7 marked this pull request as ready for review August 5, 2022 14:12
@mattcosta7 mattcosta7 requested a review from a team as a code owner August 5, 2022 14:12
mattcosta7
mattcosta7 commented Aug 5, 2022
View reviewed changes
package.json
@@ -38,6 +38,7 @@
"jest": "^27.5.1",
"js-yaml": "^4.1.0",
"prettier": "2.7.1",
"terser": "^5.14.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vulnerability bump - just to remove the warning

jayspadie
jayspadie approved these changes Aug 5, 2022
View reviewed changes
Copy link

@jayspadie jayspadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, you're quick.

@mattcosta7 mattcosta7 merged commit 3ac4188 into main Aug 5, 2022
@mattcosta7 mattcosta7 deleted the changeset-in-details-with-details branch August 5, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayspadie jayspadie jayspadie approved these changes

@camchenry camchenry Awaiting requested review from camchenry

Assignees

@mattcosta7 mattcosta7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattcosta7 @jayspadie