Update README.md #203
Update README.md #203
Conversation
| @@ -56,7 +56,7 @@ jobs: | |||
| - name: Build | |||
| run: npm run build | |||
| - name: Upload stats.json | |||
| uses: actions/upload-artifact@v1 | |||
| uses: actions/upload-artifact@v3 | |||
There was a problem hiding this comment.
it might be better to avoid suggesting the version at all here, otherwise we'll need to updatet the docs as this changes
There was a problem hiding this comment.
but version is required for real case
There was a problem hiding this comment.
I don't believe that's true? most actions use main if no version is provided. Users should use a version, but adding details about that here doesn't seem helpful to say they must use a specific version if that's not true all the time
we could add a single note about versioning, directing to the docs for that
There was a problem hiding this comment.
There was a problem hiding this comment.
hm - interesting, it shouldn't be required, but maybe related to how versions are tagged currently, thanks!
| runs-on: ubuntu-latest | ||
| needs: [build-base, build-head] | ||
| steps: | ||
| - uses: actions/download-artifact@v3 |
There was a problem hiding this comment.
we should probably avoid including a version here
| needs: [build-base, build-head] | ||
| steps: | ||
| - uses: actions/download-artifact@v3 | ||
| - uses: github/webpack-bundlesize-compare-action@v1.5.0 |
There was a problem hiding this comment.
I don't think we should include a specific version here, otherwise we're likely to forget to add this when the next release occurs.
There was a problem hiding this comment.
| - uses: github/webpack-bundlesize-compare-action@v1.5.0 | |
| # Run the comparison action | |
| # Remember to use a specific sha or version | |
| # github/webpack-bundlesize-compare-action@v<x.x.x> or github/webpack-bundlesize-compare-action@<sha> | |
| - uses: github/webpack-bundlesize-compare-action |
There was a problem hiding this comment.
version is required and as an example it may be better for people to just "copy-paste-go"
There was a problem hiding this comment.
AFAIK most action examples write this way
https://github.com/marketplace/actions/upload-a-build-artifact#usage
https://github.com/marketplace/actions/setup-node-js-environment#usage
No description provided.