Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid threshold check #9

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Avoid threshold check #9

merged 2 commits into from
Jan 10, 2022

Conversation

mattcosta7
Copy link
Member

Get rid of the theshold check until we can determine a good level

@mattcosta7 mattcosta7 self-assigned this Jan 10, 2022
@mattcosta7 mattcosta7 requested a review from a team as a code owner January 10, 2022 16:32
@github-actions
Copy link

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 1.34 MB 1.29 MB -53.7 KB -3.91%
View detailed bundle breakdown

Added

No assets were added

Removed

Asset Old size New size Diff Diff %
296.chunk.js 125 KB 0 -125 KB -100.00%
288.chunk.js 57.2 KB 0 -57.2 KB -100.00%
920.chunk.js 55 KB 0 -55 KB -100.00%
912.chunk.js 44.4 KB 0 -44.4 KB -100.00%
699.chunk.js 26.4 KB 0 -26.4 KB -100.00%

Bigger

Asset Old size New size Diff Diff %
app.bundle.js 1.04 MB 1.29 MB 254 KB 23.91%

Smaller

Asset Old size New size Diff Diff %
manifest.json 551 bytes 91 bytes -460 bytes -83.48%

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats-Flipped around

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 1.29 MB 1.34 MB 53.7 KB 4.07%
View detailed bundle breakdown

Added

Asset Old size New size Diff Diff %
296.chunk.js 0 125 KB 125 KB -
288.chunk.js 0 57.2 KB 57.2 KB -
920.chunk.js 0 55 KB 55 KB -
912.chunk.js 0 44.4 KB 44.4 KB -
699.chunk.js 0 26.4 KB 26.4 KB -

Removed

No assets were removed

Bigger

Asset Old size New size Diff Diff %
manifest.json 91 bytes 551 bytes 460 bytes 505.49%

Smaller

Asset Old size New size Diff Diff %
app.bundle.js 1.29 MB 1.04 MB -254 KB -19.29%

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats-Non existant

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 0 0 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@github-actions
Copy link

Bundle Stats-No changes

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 1.34 MB 1.34 MB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
app.bundle.js 1.04 MB 1.04 MB 0 0.00%
296.chunk.js 125 KB 125 KB 0 0.00%
288.chunk.js 57.2 KB 57.2 KB 0 0.00%
920.chunk.js 55 KB 55 KB 0 0.00%
912.chunk.js 44.4 KB 44.4 KB 0 0.00%
699.chunk.js 26.4 KB 26.4 KB 0 0.00%
manifest.json 551 bytes 551 bytes 0 0.00%

@mattcosta7 mattcosta7 merged commit fb1ebe3 into main Jan 10, 2022
@mattcosta7 mattcosta7 deleted the avoid-threshold-check branch January 10, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant