Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): use system browser for GitHub SSO / OAuth authentication #1781

Merged
merged 17 commits into from
Jan 29, 2025

Conversation

setchy
Copy link
Member

@setchy setchy commented Jan 27, 2025

Closes #1764, #1761, #485

Changes

  • register new custom protocol gitify://
  • launch system browser for authentication flow
  • create new OAuth2 app with new callback for development/testing

Backwards Compatibility
For backwards compatibility, the existing GitHub OAuth Apps for Gitify authentication will remain untouched, along with the callback handling at gitify.io/callback for a period of time.

Checklist

  • update website FAQ docs for OAuth2 callback url - see docs: update for v6 release website#328
  • resolve account mgmt render issue when adding/remove accounts
  • create production OAuth2 app with new callback

Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Jan 27, 2025
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy marked this pull request as draft January 27, 2025 12:44
@setchy setchy added this to the Release 6.0.0 milestone Jan 27, 2025
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy and others added 7 commits January 28, 2025 07:37
Co-authored-by: Brendan Mulholland <github@bmulholland.ca>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy marked this pull request as ready for review January 28, 2025 22:21
@setchy setchy requested a review from bmulholland January 28, 2025 22:21
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy merged commit 5712df1 into main Jan 29, 2025
12 checks passed
@setchy setchy deleted the feat/rewrite-github-sso branch January 29, 2025 14:57
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Exciting to see where v6 will take us :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub App (SSO) Authentication
3 participants