Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current line blame no showing #939

Closed
masics opened this issue Jan 27, 2020 · 17 comments
Closed

Current line blame no showing #939

masics opened this issue Jan 27, 2020 · 17 comments
Assignees
Labels
bug Something isn't working needs-more-info Needs further information, steps, details, etc.

Comments

@masics
Copy link

masics commented Jan 27, 2020

The "current line blame" is not showing anymore.

  • GitLens Version:
    Extension version: 10.2.0
    VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
    OS version: Windows_NT x64 10.0.18363
    Remote OS version: Linux x64 4.4.0-18362-Microsoft
    Remote OS version: Linux x64 4.4.0-18362-Microsoft

Debug after changing line with a mouse:

[2020-01-27 03:25:18:171] [6b] LineAnnotationController.onActiveLinesChanged — e=editor=file:///c:/projects/myfile.txt, lines=undefined, pending=true, reason=selection
[2020-01-27 03:25:18:171] [6c] LineAnnotationController.clear completed • 0 ms
[2020-01-27 03:25:18:171] [6b] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2020-01-27 03:25:18:171] [6d] LineHoverController.onActiveLinesChanged — e=editor=file:///c:/projects/myfile.txt, lines=undefined, pending=true, reason=selection
[2020-01-27 03:25:18:171] [6d] LineHoverController.onActiveLinesChanged completed • 0 ms
[2020-01-27 03:25:18:171] [6e] StatusBarController.onActiveLinesChanged — e=editor=file:///c:/projects/myfile.txt, lines=undefined, pending=true, reason=selection
[2020-01-27 03:25:18:171] [6e] StatusBarController.onActiveLinesChanged completed • 0 ms
[2020-01-27 03:25:18:422] [6f] LineAnnotationController.onActiveLinesChanged — e=editor=file:///c:/projects/myfile.txt, lines=undefined, pending=false, reason=selection
[2020-01-27 03:25:18:422] [70] LineAnnotationController.clear completed • 0 ms
[2020-01-27 03:25:18:422] [6f] LineAnnotationController.onActiveLinesChanged completed • 0 ms
[2020-01-27 03:25:18:422] [71] LineHoverController.onActiveLinesChanged — e=editor=file:///c:/projects/myfile.txt, lines=undefined, pending=false, reason=selection
[2020-01-27 03:25:18:422] [71] LineHoverController.onActiveLinesChanged completed • 0 ms
[2020-01-27 03:25:18:422] [72] StatusBarController.onActiveLinesChanged — e=editor=file:///c:/projects/myfile.txt, lines=undefined, pending=false, reason=selection
[2020-01-27 03:25:18:423] [72] StatusBarController.onActiveLinesChanged completed • 0 ms

@waracci
Copy link

waracci commented Jan 27, 2020

Same case for macOs Mohave Version 10.14.5.

VsCode Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0

Git lens version 10.2.0

@konradsa
Copy link

konradsa commented Feb 10, 2020

Same here after upgrading to VSCode 1.42. Checked the settings and tried the toggle, but nto shown anymore.

@eamodio
Copy link
Member

eamodio commented Feb 11, 2020

What version of Git are you all using? Any chance 10.2.1 fixes the issue?

@eamodio eamodio self-assigned this Feb 11, 2020
@eamodio eamodio added the needs-more-info Needs further information, steps, details, etc. label Feb 11, 2020
@masics
Copy link
Author

masics commented Feb 11, 2020

What version of Git are you all using? Any chance 10.2.1 fixes the issue?

2.25.0.windows.1

@eamodio
Copy link
Member

eamodio commented Feb 11, 2020

@masics Thanks -- Git 2.25 definitely caused a bunch of issues with GitLens. Can you try 10.2.1 and see if it fixes things?

@masics
Copy link
Author

masics commented Feb 11, 2020

@masics Thanks -- Git 2.25 definitely caused a bunch of issues with GitLens. Can you try 10.2.1 and see if it fixes things?

Are there any chances you will adopt 2.25+?

@eamodio
Copy link
Member

eamodio commented Feb 11, 2020

As long as Git doesn't have another breaking change it should be fine (2.25 was the first time I've had to deal with Git breaking things)

@masics
Copy link
Author

masics commented Feb 11, 2020

As long as Git doesn't have another breaking change it should be fine (2.25 was the first time I've had to deal with Git breaking things)

What exactly it broke?

@Conduitry
Copy link

I still had a bunch of broken features with gitlens 10.2.1, git 2.25.0. For now I've downgraded the version of git used by vscode.

@eamodio
Copy link
Member

eamodio commented Mar 10, 2020

@Conduitry what broken issues have you seen with Git 2.25 and GitLens 10.2.1? If you are still seeing issues, please file them.

@eamodio
Copy link
Member

eamodio commented Mar 23, 2020

I am closing this issue because it needs more information and has not had recent activity. Please re-open this issue when more details can be provided.

Thanks!

@eamodio eamodio closed this as completed Mar 23, 2020
@masics masics changed the title Current line blame now showing Current line blame no showing Mar 23, 2020
@masics
Copy link
Author

masics commented Mar 23, 2020

I still don't see the blame lines. What extra information do you require?

@eamodio
Copy link
Member

eamodio commented Mar 23, 2020

@masics Are you using 10.2.1? If so, does the folder you are opening in vscode match the casing of the folder on disk? (VS Code has issues if there is any casing differences because what is on disk and how you open the folder in VS Code -- which then causes GitLens issues).

@masics
Copy link
Author

masics commented Mar 23, 2020 via email

@eamodio
Copy link
Member

eamodio commented Mar 23, 2020

See microsoft/vscode#12448
Also the main issue you are hitting with GitLens is that Git isn't case-insensitive by default. So to fix this, you either need to open the folder in vscode exactly as it is on disk (recommended, as you will likely hit other issues), or change you Git config to ignore case:
https://stackoverflow.com/questions/52950/how-to-make-git-ignore-changes-in-case#53116

Hope that helps.

@masics
Copy link
Author

masics commented Mar 23, 2020 via email

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2020
@eamodio eamodio added bug Something isn't working and removed potential-bug labels Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-more-info Needs further information, steps, details, etc.
Projects
None yet
Development

No branches or pull requests

5 participants