[openfga] Configure cloud-sql-proxy sidecar #15692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: SID
team: webapp
easyCZ
force-pushed
the
mp/openfga-cloud-sql-proxy-sidecar
branch
from
eada9e6 to
4b355ce
Compare
ArthurSens
approved these changes
Jan 11, 2023
4 tasks
easyCZ
force-pushed
the
mp/openfga-cloud-sql-proxy-sidecar
branch
from
4b355ce to
a3c2f52
Compare
andrew-farries
approved these changes
Jan 12, 2023
Comment on lines
+62
to
+65
| Requests: corev1.ResourceList{ | ||
| "cpu": resource.MustParse("1m"), | ||
| "memory": resource.MustParse("30Mi"), | ||
| }, |
There was a problem hiding this comment.
Where are these resource limits taken from, or are they an initial best guess?
There was a problem hiding this comment.
An initial one, just picked something small. They are just requests (not limits) so it will realistically consume more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a cloud-sql-proxy sidecar to the
openfgadeployment, if a CloudSQL config is specified.We require that the
openfgadeployment talks to a database in a single region. That means we can't use the existing cloud-sql-proxy because that is configured to talk to a regional instance.Related Issue(s)
How to test
Not really testable in preview, will need to validate on staging with config.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh