[server] fix deleteUser permissions #18989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
reviewed
Oct 31, 2023
svenefftinge
force-pushed
the
se/delete-fix
branch
from
c498999
to
435969b
Compare
svenefftinge
force-pushed
the
se/delete-fix
branch
from
435969b
to
7206685
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
deletepermission on users, so that admins and org owners can delete their users.Also moves the
deleteUserfunction toUserServiceand introduces an event hook for other services to participate in a user deletion.Summary generated by Copilot
🤖 Generated by Copilot at c498999
Refactored user deletion logic to use UserService as the main entry point and UserDeletionService as a listener. Added tests and updated permissions for deleting users. Simplified and removed unused code.
Related Issue(s)
Fixes EXP-833
How to test
Signup with two users. make one an admin and delete the other one.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold