Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] add vscode(-insiders) ouath2 clients #6272

Merged
merged 1 commit into from
Apr 12, 2022
Merged

[server] add vscode(-insiders) ouath2 clients #6272

merged 1 commit into from
Apr 12, 2022

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Oct 18, 2021 •
edited by akosyakov
Loading

Description

It adds 2 new oauth2 clients for Gitpod Server: VS Code Desktop and VS Code Desktop Insiders.

Related Issue(s)

#3733

How to test

Check that the local app is still working.

Release Notes

NONE

Documentation

@roboquat roboquat added team: webapp Issue belongs to the WebApp team size/L labels Oct 18, 2021
@filiptronicek filiptronicek mentioned this pull request Oct 18, 2021
Closed
@filiptronicek
Copy link
Member Author

filiptronicek commented Oct 19, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.1

@akosyakov akosyakov mentioned this pull request Oct 20, 2021
Closed
8 tasks
@akosyakov
Copy link
Member

akosyakov commented Oct 20, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.2

@akosyakov
Copy link
Member

akosyakov commented Oct 21, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.3

@akosyakov
Copy link
Member

akosyakov commented Oct 21, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.4

@akosyakov
Copy link
Member

akosyakov commented Oct 22, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.5

@akosyakov
Copy link
Member

akosyakov commented Oct 22, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.6

@akosyakov akosyakov force-pushed the server_vscode_oauth2 branch from 8d0cb95 to 265ce2c Compare October 22, 2021 09:58
@akosyakov
Copy link
Member

akosyakov commented Oct 22, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.9

@akosyakov akosyakov force-pushed the server_vscode_oauth2 branch 2 times, most recently from 4ccda96 to 1029829 Compare October 22, 2021 12:08
@akosyakov akosyakov marked this pull request as ready for review October 22, 2021 12:09
geropl
geropl reviewed Nov 1, 2021
View reviewed changes
components/gitpod-db/src/typeorm/user-db-impl.ts Outdated
@@ -419,7 +419,7 @@ export class TypeORMUserDBImpl implements UserDB {
} else {
var user: MaybeUser;
if (accessToken.user) {
user = await this.findUserById(accessToken.user.id)
user = await this.findUserById(String(accessToken.user.id))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we never use String. In this case maybe .toString() would be a more idiomatic solution.

@geropl
Copy link
Member

geropl commented Nov 1, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.12

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Nov 16, 2021
@akosyakov
Copy link
Member

akosyakov commented Nov 17, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Added team IDE because merging actually blocked by me 😅

@JanKoehnlein
Copy link
Contributor

Closing this for now. see internal discussion.

This was referenced Apr 5, 2022
Closed
Closed
@filiptronicek filiptronicek reopened this Apr 5, 2022
@filiptronicek filiptronicek requested a review from a team April 6, 2022 08:37
@filiptronicek filiptronicek marked this pull request as draft April 6, 2022 08:38
@filiptronicek filiptronicek force-pushed the server_vscode_oauth2 branch from 66a2b05 to 71c83cb Compare April 6, 2022 08:59
@filiptronicek
Copy link
Member Author

filiptronicek commented Apr 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-server-vscode-oauth2.19

@jeanp413
Copy link
Member

jeanp413 commented Apr 11, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-server-vscode-oauth2.22

@jeanp413 jeanp413 force-pushed the server_vscode_oauth2 branch 2 times, most recently from ec64495 to aaa462c Compare April 11, 2022 18:00
@jeanp413 jeanp413 marked this pull request as ready for review April 11, 2022 18:14
@jeanp413 jeanp413 force-pushed the server_vscode_oauth2 branch from aaa462c to 5a2989a Compare April 11, 2022 18:19
@jeanp413
Copy link
Member

@geropl could you review this 🙏

@jeanp413
Copy link
Member

/unhold

geropl
geropl approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit a78f4ef into main Apr 12, 2022
@roboquat roboquat deleted the server_vscode_oauth2 branch April 12, 2022 07:42
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@geropl geropl geropl approved these changes

@JanKoehnlein JanKoehnlein Awaiting requested review from JanKoehnlein

@mrsimonemms mrsimonemms Awaiting requested review from mrsimonemms

Assignees

@JanKoehnlein JanKoehnlein

@geropl geropl

Labels
approved deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@filiptronicek @akosyakov @geropl @roboquat @JanKoehnlein @jeanp413