Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] Build stable image for 1.66 and use it in Insiders #9044

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Mar 31, 2022

Description

Update code to 1.66

How to test

  • Switch to VS Code Insiders in settings.
  • Start a workspace.
  • Test following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restart, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually sync in new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded on the PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

NONE

@filiptronicek
Copy link
Member Author

filiptronicek commented Mar 31, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-ft-produce-stable-code-1.66.3

@mustard-mh
Copy link
Contributor

mustard-mh commented Mar 31, 2022

just see it😅

@mustard-mh
Copy link
Contributor

I checked last two

@mustard-mh mustard-mh self-requested a review March 31, 2022 12:11
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mustard-mh
Copy link
Contributor

mustard-mh commented Mar 31, 2022

/werft run

👍 started the job as gitpod-build-ft-produce-stable-code-1.66.7

I removed segment to make it build success

@roboquat roboquat merged commit ff4faf6 into main Mar 31, 2022
@roboquat roboquat deleted the ft/produce-stable-code-1.66 branch March 31, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants