Fix default vscode settings sync value

[jeanp413]

Description

Fix default vscode settings sync value

How to test

1. Bundle gitpod-desktop vsix from Implement gitpod auth and settings sync openvscode-server#337 Dowload this vsix file gitpod-desktop-0.0.30.zip
2. Install vsix in vscode desktop
3. Press F1 and execute Gitpod: Turn on Settings Sync command
4. Close all windows
5. Reopen vscode and enable settings sync: Press f1 and execute Settings Sync: Turn On... command (make sure you have some local settings already modified)
6. When it prompts to resolve conflicts, choose manual
7. Observe diff editor for settings.json shows remote value as {} (empty object) instead of {settings:""}

Release Notes

NONE

[akosyakov]

@jeanp413 It would be nice if you can provide vsix file, otherwise it takes time to verify.

[jeanp413]

Added the vsix file in description

[geropl]

I'm not sure how to test this. I followed the steps, but I did not see a conflict (used to sync with GitHub...?).
I assume I skipped some prior steps to do?

[jeanp413]

@geropl sorry about that I missed some steps, I updated it in the description.

[akosyakov]

Setting sync worked for me, but I did not see any resolve conflict windows and could not follow verification steps because of it.

[akosyakov]

Settings sync worked btw, but extensions although synced were not installed, also I see errors in setting sync output:

Here exported logs: vscodeLogs.zip

btw we should generate better file names for logs, something like ${workspace-id}-vscode-web-logs.zip

[jeanp413]

@akosyakov I see you had already some data in your account try deleting your sync data first and then settings sync again in vscode desktop
About the error seems an issue with openvsx maybe you were just unlucky, could you try again

[2022-04-14 09:37:01.468] [window] [error] [Extension Host] Fetch failed while querying open-vsx FetchError: network timeout at: https://open-vsx.jp-oauth-test.staging.gitpod-dev.com/api/-/query
	at Timeout.<anonymous> (/ide/extensions/gitpod-web/dist/extension.js:2:666420)

btw we should generate better file names for logs, something like ${workspace-id}-vscode-web-logs.zip

we don't have acces to workspace-id in core vscode unless we parse the gitpod extension logs file before zipping it

[geropl]

I tested again, and see:

• {} for settings.json
• empty file for keybindings.json
• [] for extensions.json
  @jeanp413 Is that expected?
  

[jeanp413]

@geropl yep that's fine, that's from the theia settings migration logic fine for now until we remove it 👍