Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Collect all logs command to gitpod-desktop #344

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Add Collect all logs command to gitpod-desktop #344

merged 1 commit into from
Apr 26, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Apr 22, 2022 •
edited
Loading

  • Adds Collect all logs command to gitpod-desktop
  • Improve terminal task logging
  • Fixes an issue with tasks terminal where requests where still being made after the tasks was killed

This PR fixes gitpod-io/gitpod#9431

gitpod-extensions.zip

@jeanp413 jeanp413 requested a review from akosyakov April 22, 2022 04:49
@akosyakov
Copy link
Member

akosyakov commented Apr 22, 2022 •
edited
Loading

Needs #337 to be merged first, if not changes in gitpod-desktop would create merge conflicts in #337 and also the refactor was a needed change.

Could we do it another way around please and land this rather sooner? 🙏 Helping customers is more important.

@jeanp413 jeanp413 force-pushed the jp/remote-logging branch 4 times, most recently from 5688d0d to 9621a35 Compare April 23, 2022 15:33
@akosyakov
Copy link
Member

I think it looks good besides file naming. I think it should be more precise that we could tell from file name what was used to collect it and in which context.

@jeanp413 jeanp413 force-pushed the jp/remote-logging branch 2 times, most recently from 7f9682a to f83e059 Compare April 25, 2022 19:53
akosyakov
akosyakov approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeanp413 jeanp413 merged commit 2e8070a into gp-code/main Apr 26, 2022
@jeanp413 jeanp413 deleted the jp/remote-logging branch April 26, 2022 14:18
@jeanp413 jeanp413 mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanp413 @akosyakov