Skip to content

Commit

Permalink
Fix typo in _get_exe_extensions PATHEXT fallback
Browse files Browse the repository at this point in the history
PATHEXT lists file extensions with the ".". In the fallback given
in _get_exe_extensions, the other extensions had this, but ".COM"
was listed without the ".". This fixes that.

This is very minor because _get_exe_extensions is nonpublic and not
currently used on native Windows, which is the platform where the
PATHEXT fallback code would be used.

Specifically, _get_exe_extensions is called only in py_where, which
while named with no leading underscore is nonpublic do not being
(and never having been) listed in __all__. As its docstring states,
it is an implementation detail of is_cygwin_git and not intended
for any other use. More specifically, is_cygwin_git currently
immediately returns False on *native* Windows (even if the git
executable GitPython is using is a Cygwin git executable). Only on
Cygwin, or other systems that are not native Windows, does it try
to check the git executable (by calling its _is_cygwin_git helper,
which uses py_where).
  • Loading branch information
EliahKagan committed Mar 31, 2024
1 parent 83bed19 commit 988d97b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ def _get_exe_extensions() -> Sequence[str]:
if PATHEXT:
return tuple(p.upper() for p in PATHEXT.split(os.pathsep))
elif sys.platform == "win32":
return (".BAT", "COM", ".EXE")
return (".BAT", ".COM", ".EXE")
else:
return ()

Expand Down

0 comments on commit 988d97b

Please sign in to comment.