Drop python 3.4, prep for adding types #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yobmod
commented
Feb 28, 2021
•
Yobmod
commented
- Drop python 3.4 in setup.py and tox.ini
- Update .gitnignore
- Add mypy.ini
- Add git/py.typed file and to setup.py
- add test/testrunner.py as a hook for monkeytype
- Add git/types.py for type aliases and classes
- (Some commits just formatting. VSCode switched my flake8 off for mypy)
|
I've had to rename testrunner.py as it was interferring with the checks. Feel free to change to a better name! |
|
Thanks a lot! Please let me know if this is a draft (and I will make it a draft PR) or when it's ready to be merged as foundation for types (I really don't know much anything about that and rely solely on your expertise, thanks in advance for bearing my ignorance 😅). |
|
I think this is ready to merge as is. |
|
Thanks a lot, I am looking forward to seeing the first types :)! |
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Oct 23, 2023
It benefits from a docstring because it is not referenced in code or documentation, and its purpose is/was otherwise unclear. The docstring includes a reference to gitpython-developers#1188 for more information.
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Oct 23, 2023
It benefits from a docstring because it is not referenced in code or documentation, and its purpose is/was otherwise unclear. The docstring includes a reference to gitpython-developers#1188 for more information.
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Oct 23, 2023
It benefits from a docstring because it is not referenced in code or documentation, and its purpose is/was otherwise unclear. The docstring includes a reference to gitpython-developers#1188 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.