Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in _get_exe_extensions PATHEXT fallback #1890

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix typo in _get_exe_extensions PATHEXT fallback #1890

merged 2 commits into from
Apr 2, 2024

Commits on Mar 31, 2024

  1. Fix wording of comment about the /cygdrive prefix

    @EliahKagan
    EliahKagan committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    83bed19 View commit details
    Browse the repository at this point in the history

  2. Fix typo in _get_exe_extensions PATHEXT fallback 

    PATHEXT lists file extensions with the ".". In the fallback given
in _get_exe_extensions, the other extensions had this, but ".COM"
was listed without the ".". This fixes that.

This is very minor because _get_exe_extensions is nonpublic and not
currently used on native Windows, which is the platform where the
PATHEXT fallback code would be used.

Specifically, _get_exe_extensions is called only in py_where, which
while named with no leading underscore is nonpublic do not being
(and never having been) listed in __all__. As its docstring states,
it is an implementation detail of is_cygwin_git and not intended
for any other use. More specifically, is_cygwin_git currently
immediately returns False on *native* Windows (even if the git
executable GitPython is using is a Cygwin git executable). Only on
Cygwin, or other systems that are not native Windows, does it try
to check the git executable (by calling its _is_cygwin_git helper,
which uses py_where).
    @EliahKagan
    EliahKagan committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    988d97b View commit details
    Browse the repository at this point in the history