Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpine Linux in WSL on CI #1945

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Commits on Jul 24, 2024

  1. Use Alpine Linux in WSL on CI

    Some of the CI tests use WSL. This switches the WSL distribution
    from Debian to Alpine, which might be slightly faster. For the way
    it is being used here, the main expected speed improvement would be
    to how long the image would take to download, as Alpine is smaller.
    
    (The reason for this is thus unrelated to the reason for the Alpine
    docker CI test job added in gitpython-developers#1826. There, the goal was to test on a
    wider variety of systems and environments, and that runs the whole
    test suite in Alpine. This just changes the WSL distro, used by a
    few tests on Windows, from Debian to Alpine.)
    
    Two things have changed that, taken together, have unblocked this:
    
    - Vampire/setup-wsl#50 was fixed, so the
      action we are using is able to install Alpine Linux. See:
      gitpython-developers#1917 (review)
    
    - gitpython-developers#1893 was fixed in gitpython-developers#1888. So if switching the WSL distro from
      Debian to Alpine breaks any tests, including by making them fail
      in an unexpected way that raises the wrong exception, we are
      likely to find out.
    EliahKagan committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    58a9a58 View commit details
    Browse the repository at this point in the history
  2. Install bash in WSL Alpine distro

    Because Alpine Linux does not ship with bash, and the tests that
    use WSL use it.
    EliahKagan committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    055394a View commit details
    Browse the repository at this point in the history