it: more reliable successful download test

giulong · Dec 31, 2024 · 24eac4b · 24eac4b
1 parent 31ab229
commit 24eac4b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/it/src/test/java/io/github/giulong/spectrum/it/pages/DownloadPage.java b/it/src/test/java/io/github/giulong/spectrum/it/pages/DownloadPage.java
@@ -9,6 +9,8 @@
 
 import java.util.List;
 
+import static io.github.giulong.spectrum.it.tests.FilesIT.FILE_TO_UPLOAD;
+
 @Getter
 @Endpoint("download")
 @SuppressWarnings("unused")
@@ -20,4 +22,7 @@ public class DownloadPage extends SpectrumPage<DownloadPage, Void> {
             @FindBy(tagName = "a"),
     })
     private List<WebElement> downloadLinks;
+
+    @FindBy(linkText = FILE_TO_UPLOAD)
+    private WebElement spectrumLogo;
 }
diff --git a/it/src/test/java/io/github/giulong/spectrum/it/tests/FilesIT.java b/it/src/test/java/io/github/giulong/spectrum/it/tests/FilesIT.java
@@ -13,9 +13,8 @@
 @SuppressWarnings("unused")
 public class FilesIT extends SpectrumTest<Void> {
 
-    // this must be different from the downloaded file since herokuapp will randomly serve exactly the files used to test the upload
+    public static final String FILE_TO_UPLOAD = "spectrum-logo.png";
     private static final String FILE_TO_DOWNLOAD = "empty.txt";
-    private static final String FILE_TO_UPLOAD = "spectrum-logo.png";
 
     private DownloadPage downloadPage;
     private UploadPage uploadPage;
@@ -58,11 +57,7 @@ public void upload() {
 
         downloadPage
                 .open()
-                .getDownloadLinks()
-                .stream()
-                .filter(webElement -> webElement.getText().equals(FILE_TO_UPLOAD))
-                .findFirst()
-                .orElseThrow()
+                .getSpectrumLogo()
                 .click();
 
         assertTrue(checkDownloadedFile(FILE_TO_UPLOAD));

diff --git a/...rc/test/java/io/github/giulong/spectrum/verify_browsers/tests/ExtentReportVerifierIT.java b/...rc/test/java/io/github/giulong/spectrum/verify_browsers/tests/ExtentReportVerifierIT.java
@@ -85,7 +85,7 @@ private void commonChecksFor(final String url) {
         assertEquals("3", extentReportPage.getVideoLoginFormItWithUserGiulioWeExpectLoginToBeSuccessfulFalse().getDomProperty("duration"));
         assertEquals("3", extentReportPage.getVideoLoginFormItWithUserTomWeExpectLoginToBeSuccessfulTrue().getDomProperty("duration"));
 
-        assertEquals("17", extentReportPage.getVideoFilesItUpload().getDomProperty("duration"));
+        assertEquals("2", extentReportPage.getVideoFilesItUpload().getDomProperty("duration"));
         assertEquals("1", extentReportPage.getVideoFilesItDownload().getDomProperty("duration"));
 
         // check screenshot was added programmatically with the screenshotInfo(String) method