ignore :is pseudoclass as parentheses can contain unhandled spaces and further pseudoclasses #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- without `allCombinations`, the space within the brackets is not escaped, so currently we get a unusable class of `a\:is\(.\:hover, .current)`, which also has an unescaped closing bracket - even without `allCombinations` it's reasonable to expect the `:is` to be maintained as-is, so that explicit `.\:hover` classes can be programmatically added without having to add classes for each of the `:is` rules in the stylesheet, which can be non-trivial
…solution:
a:is(:hover, .\:hover, .current),
a.\:is\(\:hover\,\ \.current\) {
color: firebrick;
}
|
This came about due to a test case from the following PR in another repository: rrweb-io/rrweb#1535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:iswas escaped, the space within the brackets was not escaped and we got a unusable class ofa\:is\(.\:hover, .current), which also has an unescaped closing bracketallCombinationsit's reasonable to expect the:isto be maintained as-is, so that explicit.\:hoverclasses can be programmatically added without having to add classes for each of the:isrules in the stylesheet, which is likely to be non-trivial given how this pseudoclass is used in the wild.I've solved in this PR by blacklisting
:is, but possibly there is a better solution out there which IMO would need to replicate some of the effect ofallCombinationseven in the absence of that option.Example ideal solution, not implemented in this PR:
Above demonstrates recursive addition of new class within the 'sub selector' of the :is parenthesis, as well as proper escaping of a full :is statement (which I can't imagine anyone ever using)